This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
New api to query queue size based on task type and domain #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxu-nflx
approved these changes
May 5, 2022
| @@ -111,6 +111,17 @@ public Map<String, Integer> size( | |||
| return taskService.getTaskQueueSizes(taskTypes); | |||
| } | |||
|
|
|||
| @GetMapping("/queue/size") | |||
There was a problem hiding this comment.
Can the API above in line 107 - @GetMapping("/queue/sizes") be modified to support this?
There was a problem hiding this comment.
If i were to modify it, i would make it like the new api that's added. /queue/sizes accepts a list and is unbounded. We can deprecate /queue/sizes and remove it in an upcoming release.
apanicker-nflx
approved these changes
May 9, 2022
apanicker-nflx
approved these changes
May 9, 2022
jxu-nflx
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
A new api that can query task queue sizes based on task type and domain
Alternatives considered
None