This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix update with large payload task result #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
force-pushed
the
client_large_payload_fix
branch
from
94f89c5
to
22bef37
Compare
apanicker-nflx
changed the title
apanicker-nflx
force-pushed
the
client_large_payload_fix
branch
from
22bef37
to
95bb8e4
Compare
jxu-nflx
reviewed
May 10, 2022
| operation.apply(taskResult); | ||
| return taskResult; | ||
| Optional<String> optionalExternalStorageLocation = operation.apply(result); | ||
| if (optionalExternalStorageLocation.isPresent()) { |
There was a problem hiding this comment.
This is confusing. Can we create two retryOperation method? one for the uploadtoexternalstorage, which takes a taskresult output map and returns an externalstoragepath, another one for the updatetask, which takes the final taskresult from last step, and return void
There was a problem hiding this comment.
If we want to keep just one retryoperation method, we can just remove line #313 TaskResult taskResult = result.copy(); from it. I don't see the point of why we want to make a copy of it for every retry
aravindanr
approved these changes
May 10, 2022
jxu-nflx
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Fixes a bug where large payload location in task result was not being propagated as part of task result by the client.