This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
re-throw TerminateWorkflowException if payload exceed max threshold s… #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o to fail workflow and task
test-harness/src/test/java/com/netflix/conductor/test/utils/MockExternalPayloadStorage.java
Show resolved
Hide resolved
aravindanr
reviewed
Oct 6, 2022
| @@ -192,6 +192,8 @@ public <T> void verifyAndUpload(T entity, PayloadType payloadType) { | |||
| } | |||
| } catch (TransientException te) { | |||
| throw te; | |||
| } catch (TerminateWorkflowException twe) { | |||
There was a problem hiding this comment.
I presume that this fails the workflow, but the task whose payload is large will not be marked as FAILED. Should we try to fail the respective task?
There was a problem hiding this comment.
It will fail the task as well if the terminateworkflowexception is due to task exceed size limit:
There is a test case added verified that as well
apanicker-nflx
approved these changes
Oct 10, 2022
aravindanr
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o to fail workflow and task
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Fix the issue that if a task output exceed threshold, the workflow appears to be stuck in RUNNING state.
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered