This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Set scheduledTime and startTime with currentTime for all system tasks #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Oct 7, 2022
aravindanr
reviewed
Oct 7, 2022
| @@ -51,7 +51,9 @@ public List<TaskModel> getMappedTasks(TaskMapperContext taskMapperContext) { | |||
| TaskModel joinTask = taskMapperContext.createTaskModel(); | |||
| joinTask.setTaskType(TaskType.TASK_TYPE_EXCLUSIVE_JOIN); | |||
| joinTask.setTaskDefName(TaskType.TASK_TYPE_EXCLUSIVE_JOIN); | |||
| joinTask.setStartTime(System.currentTimeMillis()); | |||
| final long currentTimeMillis = System.currentTimeMillis(); | |||
| joinTask.setScheduledTime(currentTimeMillis); | |||
There was a problem hiding this comment.
taskMapperContext.createTaskModel() sets the scheduledTime already. I missed that during our discussion. I don't see a need to scheduledTime in the TaskMapper implementations.
Its possible that queueWaitTime is a non-zero value for synchronous system tasks, but as long as its not below zero, we are good.
aravindanr
reviewed
Oct 7, 2022
| @@ -192,7 +192,9 @@ public List<TaskModel> createTasks(List<TaskModel> tasks) { | |||
| // update the task_lookup table | |||
| tasks.forEach( | |||
| task -> { | |||
| task.setScheduledTime(System.currentTimeMillis()); | |||
| if (task.getScheduledTime() == 0) { | |||
There was a problem hiding this comment.
This solves the negative queue wait time.
|
nit: Title and description of this PR to be modified to maybe "fix scheduleTime of task"? |
jxu-nflx
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Set scheduledTime and startTime with currentTime for all system tasks
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered