This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
batch polling in client #3304
Merged
batch polling in client #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param numSlots the number of permits to acquire | ||
| * @return {@code true} - if permit is acquired {@code false} - if permit could not be acquired | ||
| */ | ||
| public boolean acquireSlots(int numSlots) { |
There was a problem hiding this comment.
Is it possible to delete the canPoll() method above now that this method is being used instead?
apanicker-nflx
approved these changes
Oct 18, 2022
jxu-nflx
force-pushed
the
client_batch_polling
branch
5 times, most recently
from
7f19479
to
642e867
Compare
jxu-nflx
force-pushed
the
client_batch_polling
branch
from
642e867
to
13a68e7
Compare
|
@jxu-nflx When will the next release happen ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Support to batch polling tasks in client
Alternatives considered
Describe alternative implementation you have considered