Feature/add tests coverage al #793
Conversation
…CoverageReport task
ghost
requested review from
pctreddy,
cyzhao,
kishorebanala,
apanicker-nflx and
falu2010-netflix
Codecov Report
@@ Coverage Diff @@
## dev #793 +/- ##
======================================
Coverage ? 60.07%
Complexity ? 2026
======================================
Files ? 165
Lines ? 9537
Branches ? 848
======================================
Hits ? 5729
Misses ? 3462
Partials ? 346Continue to review full report at Codecov.
|
| @@ -0,0 +1,3 @@ | |||
| codecov: | |||
| branch: master | |||
There was a problem hiding this comment.
can probably remove this as it defaults to master
| @@ -0,0 +1,3 @@ | |||
| codecov: | |||
| branch: master | |||
| # strict_yaml_branch: master # Enable this if we want to use the yml file in master to dictate the reports for all branches | |||
There was a problem hiding this comment.
Maybe a good idea to uncomment this so that the yaml file is restricted to master.
build.gradle
Outdated
| **********************************/ | ||
| task codeCoverageReport(type: JacocoReport, group: "Coverage reports") { | ||
| executionData fileTree(project.rootDir.absolutePath).include("**/build/jacoco/*.exec") | ||
| //dependsOn subprojects*.test |
There was a problem hiding this comment.
remove commented code
| allprojects { | ||
| apply plugin: 'idea' | ||
| apply plugin: 'jacoco' | ||
| apply plugin: 'eclipse' |
There was a problem hiding this comment.
why do we need eclipse and idea plugin?
There was a problem hiding this comment.
we don't but I assume other users might use both
|
@alexnetflix we only need to merge this dev, 2.0 branch is now deprecated. Please resolve the conflict then merge to dev. |
…e-AL Feature/add tests coverage al
This PR adds test coverage reports and does some minor cleanup on readme page(more badges etc)
@cyzhao @apanicker-nflx I'd suggest to merge it to both 1.12 and 2.0 for comparison on test coverage moving forward.
See how it would look like:
