This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature/grpc and rest to use shared service layer #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate most of GRPC and REST to use service layer - remove some copy-paste and dead code
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
============================================
+ Coverage 61.7% 61.79% +0.09%
- Complexity 2494 2498 +4
============================================
Files 214 214
Lines 12262 12219 -43
Branches 1197 1187 -10
============================================
- Hits 7566 7551 -15
+ Misses 4041 4013 -28
Partials 655 655
Continue to review full report at Codecov.
|
pctreddy
approved these changes
Dec 17, 2018
core/src/main/java/com/netflix/conductor/service/WorkflowBulkService.java
Show resolved
Hide resolved
core/src/main/java/com/netflix/conductor/service/WorkflowBulkService.java
Show resolved
Hide resolved
long-64
pushed a commit
to long-64/conductor
that referenced
this pull request
Oct 2, 2019
…use_shared_service_layer Feature/grpc and rest to use shared service layer
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the code for being able to add audit logic in one place(service layer, rather than gRPC and rest):
Also, add an ability to run the server on a specific HOST(ie "localhost" only) for security purposes, by default it's still "broadcast"(0.0.0.0)