Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Feature/grpc and rest to use shared service layer #900

Merged
3 commits merged into from
Dec 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2018

Prepare the code for being able to add audit logic in one place(service layer, rather than gRPC and rest):

  • remove direct DAO invocation from gRPC
  • migrate most of GRPC and REST to use an existing service layer
  • remove a few places with copy-paste and dead code

Also, add an ability to run the server on a specific HOST(ie "localhost" only) for security purposes, by default it's still "broadcast"(0.0.0.0)

Alex Lich added 3 commits December 13, 2018 21:49
- migrate most of GRPC and REST to use service layer
- remove some copy-paste and dead code
@ghost ghost requested a review from pctreddy December 14, 2018 09:58
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #900 into master will increase coverage by 0.09%.
The diff coverage is 28.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #900      +/-   ##
============================================
+ Coverage      61.7%   61.79%   +0.09%     
- Complexity     2494     2498       +4     
============================================
  Files           214      214              
  Lines         12262    12219      -43     
  Branches       1197     1187      -10     
============================================
- Hits           7566     7551      -15     
+ Misses         4041     4013      -28     
  Partials        655      655
Impacted Files Coverage Δ Complexity Δ
...netflix/conductor/service/common/BulkResponse.java 0% <ø> (ø) 0 <0> (?)
...x/conductor/server/resources/WorkflowResource.java 96.77% <ø> (-0.11%) 19 <0> (ø)
...netflix/conductor/service/WorkflowBulkService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nductor/server/resources/WorkflowBulkResource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onductor/grpc/server/service/EventServiceImpl.java 13.04% <27.27%> (-3.63%) 2 <1> (ø)
...conductor/grpc/server/service/TaskServiceImpl.java 41.3% <50%> (+0.59%) 8 <2> (ø) ⬇️
...uctor/grpc/server/service/WorkflowServiceImpl.java 37.97% <54.54%> (-3.55%) 10 <5> (-1)
...ava/com/netflix/conductor/service/TaskService.java 54.41% <57.14%> (-0.28%) 12 <1> (+2)
...com/netflix/conductor/service/WorkflowService.java 91.46% <66.66%> (-1.8%) 27 <5> (+2)
...va/com/netflix/conductor/service/EventService.java 29.41% <0%> (+29.41%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e463757...3232f77. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2135

  • 33 of 110 (30.0%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 67.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main/java/com/netflix/conductor/service/WorkflowService.java 10 12 83.33%
core/src/main/java/com/netflix/conductor/service/TaskService.java 4 7 57.14%
grpc-server/src/main/java/com/netflix/conductor/grpc/server/service/TaskServiceImpl.java 4 8 50.0%
jersey/src/main/java/com/netflix/conductor/server/resources/WorkflowBulkResource.java 0 7 0.0%
grpc-server/src/main/java/com/netflix/conductor/grpc/server/service/EventServiceImpl.java 3 11 27.27%
grpc-server/src/main/java/com/netflix/conductor/grpc/server/service/WorkflowServiceImpl.java 12 22 54.55%
core/src/main/java/com/netflix/conductor/service/WorkflowBulkService.java 0 43 0.0%
Files with Coverage Reduction New Missed Lines %
jersey/src/main/java/com/netflix/conductor/server/resources/WorkflowBulkResource.java 1 0.0%
Totals Coverage Status
Change from base Build 2107: 0.1%
Covered Lines: 8210
Relevant Lines: 12219

💛 - Coveralls

@ghost ghost changed the base branch from master to dev December 14, 2018 17:19
@ghost ghost merged commit 163f88f into dev Dec 18, 2018
@apanicker-nflx apanicker-nflx deleted the feature/grpc_and_rest_to_use_shared_service_layer branch January 2, 2019 21:53
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…use_shared_service_layer

Feature/grpc and rest to use shared service layer
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants