Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix retries logic for failed http tasks #942

Merged
1 commit merged into from Jan 15, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2019

workflow does not have task definition attached to http tasks so we can get it on demand when necessary rather than adding it to every workflow.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #942 into dev will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #942      +/-   ##
============================================
- Coverage     62.04%   62.02%   -0.03%     
  Complexity     2627     2627              
============================================
  Files           239      239              
  Lines         13046    13049       +3     
  Branches       1288     1289       +1     
============================================
- Hits           8095     8093       -2     
- Misses         4227     4232       +5     
  Partials        724      724
Impacted Files Coverage Δ Complexity Δ
...tflix/conductor/core/execution/DeciderService.java 85.47% <100%> (+0.14%) 97 <0> (+1) ⬆️
.../java/com/netflix/conductor/service/Lifecycle.java 30% <0%> (-30%) 2% <0%> (-1%)
.../com/netflix/conductor/grpc/server/GRPCServer.java 78.57% <0%> (-14.29%) 4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af05588...bd93b83. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2253

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 67.599%

Files with Coverage Reduction New Missed Lines %
grpc-server/src/main/java/com/netflix/conductor/grpc/server/GRPCServer.java 2 85.71%
core/src/main/java/com/netflix/conductor/service/Lifecycle.java 3 30.0%
Totals Coverage Status
Change from base Build 2247: -0.03%
Covered Lines: 8821
Relevant Lines: 13049

💛 - Coveralls

@ghost ghost merged commit 955bb52 into dev Jan 15, 2019
@apanicker-nflx apanicker-nflx deleted the feature/fix_http_task_retries branch January 17, 2019 21:32
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…ries

fix retries logic for failed http tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants