Improve CDK spoke account handling #9269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IAM/S3/SQS/SNS mutation permissions are needed for ConsoleMe self-service and cross-account permission mutation to work, so that change may cause confusion. Perhaps we could add a read-only configuration for folks that aren't ready to deploy fully? |
|
Agreed with @castrapel. I see three options here, in ascending order of work/involvement:
|
connelldave
force-pushed
the
issue_9248_duplicate_spoke_construct_name
branch
from
c879f86
to
a6c33ac
Compare
|
Hello both - thanks for the feedback. I fixed the CDK deployment while first exploring the project to get going - the second commit is naive on my part. I've removed the IAM commit so the basic fix can be merged and potentially come back to options 2 and 3 when I understand the codebase better :) |
…dme with how to use.
connelldave
force-pushed
the
issue_9248_duplicate_spoke_construct_name
branch
from
a6c33ac
to
1973bd4
Compare
|
@avishayil how does this look to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9248 - handle more than one "spoke" account in CDK. Added to documentation.
Reduced deployed IAM role permissions for safety: removed iam:* and other write-enabling permissions.