Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Dagger 2 #265

Closed
codefromthecrypt opened this issue Oct 18, 2014 · 1 comment
Closed

Move to Dagger 2 #265

codefromthecrypt opened this issue Oct 18, 2014 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

Dagger 1.x is not likely to continue. Dagger 2 is.

I'm interested enough to help port everything here (and maybe fix some bugs etc along the way), plus revamp upstream feign accordingly.

Please ping this issue if you feel strongly that feign should not move to Dagger 2.

@codefromthecrypt
Copy link
Contributor Author

The Dagger 2 approach is significantly incompatible with Dagger 1, particularly as multiple components with singleton scopes are unsupported, as is overrides. It is probably better to remove dagger so that callers can choose dagger 1, dagger 2, spring, guice, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant