Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Dagger 2 #120

Closed
codefromthecrypt opened this issue Oct 18, 2014 · 1 comment
Closed

Move to Dagger 2 #120

codefromthecrypt opened this issue Oct 18, 2014 · 1 comment
Assignees
@codefromthecrypt

Comments

@codefromthecrypt
Copy link
Contributor

Dagger 1.x is not likely to continue. Dagger 2 is.

I'm interested enough to help port everything here (and maybe fix some bugs etc along the way), plus revamp denominator accordingly.

Please ping this issue if you feel strongly that feign should not move to Dagger 2.
@codefromthecrypt codefromthecrypt mentioned this issue Oct 18, 2014
Closed
@codefromthecrypt codefromthecrypt self-assigned this Jan 1, 2015
@codefromthecrypt
Copy link
Contributor Author

The Dagger 2 approach is significantly incompatible with Dagger 1, particularly as multiple components with singleton scopes are unsupported, as is overrides. It is probably better to remove dagger so that callers can choose dagger 1, dagger 2, spring, guice, etc.

@codefromthecrypt codefromthecrypt mentioned this issue Jan 24, 2015
Merged
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2015
Removes Dagger 1.x Dependency
f8a46e9 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2015
Removes Dagger 1.x Dependency
4f755f2 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2015
Removes Dagger 1.x Dependency
dfbbb49 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2015
Removes Dagger 1.x Dependency
381d7ed 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 26, 2015
Removes Dagger 1.x Dependency
6da4d0e 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 26, 2015
Removes Dagger 1.x Dependency and support for javax.inject.Named
dcf098c 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

This change also drops support for javax.inject.Named, which has
been replaced by feign.Param.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 26, 2015
Removes Dagger 1.x Dependency and support for javax.inject.Named
6d87b79 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

This change also drops support for javax.inject.Named, which has
been replaced by feign.Param.

see #120
codefromthecrypt pushed a commit that referenced this issue Jan 26, 2015
Removes Dagger 1.x Dependency and support for javax.inject.Named
8a0cba5 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

This change also drops support for javax.inject.Named, which has
been replaced by feign.Param.

see #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codefromthecrypt codefromthecrypt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt