Replace TestNG with JUnit + Rules #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JUnit Rules, such as MockWebServerRule, reduce boilerplate setup present in our tests. By migrating off TestNG, and onto rules, our tests become more maintainable as JUnit is well understood.
Closed
|
denominator-pull-requests #408 SUCCESS |
|
NetflixOSS » denominator » denominator-pull-requests #33 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 3, 2015
Replace TestNG with JUnit + Rules
|
ps now no tests use guava either. the only thing left that uses guava is the CLI, but those days are numbered, too. |
| UltraDNSLiveTest.GeoReadOnlyLiveTest.class, | ||
| UltraDNSLiveTest.GeoWriteCommandsLiveTest.class | ||
| }) | ||
| public class UltraDNSLiveTest { |
There was a problem hiding this comment.
@jonbodner @jdamick Hopefully, centralizing this into one file keeps things more sane. There's mild refactoring opportunity, but I decided to stop as otherwise I'll get no more work done for the next month :) Anyway, feel free to start on the new rest provider in master, as the base test framework is at or near where I feel it should be in order to facilitate easier work in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit Rules, such as MockWebServerRule, reduce boilerplate setup present
in our tests. By migrating off TestNG, and onto rules, our tests become
more maintainable as JUnit is well understood.