fix: added extend enum, interface, union support + refactoring #122

npwork · 2021-05-05T20:55:16Z

Detailed problem description(for enum case): #118

Added support for

extend enum
extend interface
extend union

Also, I've extracted common logic to reuse it across the codebase.

…ema extensions logic

...e/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/shared/SchemaExtensionsUtils.kt

srinivasankavitha · 2021-05-06T19:15:07Z

Thanks for the PR! A minor comment, but the changes are looking good!

npwork · 2021-05-07T08:27:37Z

Fixed issue also resolved small typo

fix: added extend enum, interface, union support + refactoring of sch…

77d2a29

…ema extensions logic

npwork mentioned this pull request May 5, 2021

[bug] Extend enum doesn't work #118

Closed

srinivasankavitha requested changes May 6, 2021

View reviewed changes

...e/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/shared/SchemaExtensionsUtils.kt Outdated Show resolved Hide resolved

npwork added 2 commits May 7, 2021 11:23

fix: rename filtering function name

7a0ad8d

fix: constants generator support for extends

a94b4bf

npwork requested a review from srinivasankavitha May 7, 2021 08:28

srinivasankavitha removed their request for review May 11, 2021 17:14

srinivasankavitha approved these changes May 11, 2021

View reviewed changes

srinivasankavitha merged commit 5e1e3cf into Netflix:master May 12, 2021

Provide feedback