Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: read and use operation types from schema #327

Closed

Conversation

mcarleio
Copy link

Instead of using hardcoded values for the operation types Query, Mutation and Subscription, read type names from schema block inside the schema itself (see https://spec.graphql.org/June2018/#example-e2969) and use hardcoded values as fallback.

@berngp
Copy link
Contributor

berngp commented Jul 8, 2022

The Query, Mutation, and Subscription types are establish already as the base types for GraphQL operations by the spec.
I don't think it will be a good idea to allow folks to override it.

@berngp berngp closed this Jul 8, 2022
@mcarleio
Copy link
Author

mcarleio commented Jul 9, 2022

Hm, I agree, that Query etc are established as base types, but the GraphQL specification allows to change them and so should any compliant library do. Especially as it is not that much of an effort.
But for most people, sticking with Query etc is probably fine.

@berngp
Copy link
Contributor

berngp commented Jul 11, 2022

@srinivasankavitha what do you think?

@srinivasankavitha
Copy link
Contributor

srinivasankavitha commented Jul 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants