-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#389): allow templating for generated Java / Kotlin class names #535
base: master
Are you sure you want to change the base?
feat(#389): allow templating for generated Java / Kotlin class names #535
Conversation
Hi @BlasiusSecundus! Thank you for opening this PR, I am actively looking into this. In the meantime, could you please resolve the conflicts? |
9bb7f71
to
2cb13d9
Compare
I have resolved conflicts. However, when running the tests locally I saw
I have not noticed this before, and this also happens on master branch, so I think this should not be related to my PR. |
938bf05
to
7aa0855
Compare
@BlasiusSecundus Regarding the |
49c094c
to
4e88294
Compare
I rebased and resolved the conflicts. The aforementioned error still occurs on my machine (asl on master), but the CI build job ran successfully (on my forked repo at least). So maybe this is something related to my local setup only, I'll check. |
@BlasiusSecundus @congotej |
4e88294
to
8cf71ae
Compare
… names Adds an optional `nameTemplate` input parameter to the plugin, allowing customization of the generated Java / Kotlin class names. The following template variables are supported: - name - the original name of the class - schemaType - the GraphQL schema type (Type, Input, Interface, Enum) The default value for this new property is null. In this case the output will be identical to the current one. Examples: Given an original class name `Person` and schema type `Type`: - null -> Person - "{name}GraphQL{schemaType}" -> PersonGraphQLType - "{name}GraphQL" -> PersonGraphQL - "{name}{schemaType}" -> PersonType
8cf71ae
to
8d2dc23
Compare
Btw. This PR should also address issue #323 |
Adds an optional
nameTemplate
input parameter to the plugin, allowing customization of the generated Java / Kotlin class names.The following template variables are supported:
The default value for this new property is null. In this case the output will be identical to the current one.
Examples:
Given an original class name
Person
and schema typeType
: