Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add companion object generation for enum classes in kotlin codegen2 #670

Conversation

Salzian
Copy link
Contributor

@Salzian Salzian commented Mar 28, 2024

This PR adds the generation of a companion object into enum classes for the experimental Kotlin code gen.

This behaviour was present in the normal kotlin codegen but dissapears once

generateKotlinClosureProjections = true 
generateKotlinNullableClasses = true

Is enabled.

Copy link
Contributor

@srinivasankavitha srinivasankavitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Salzian
Copy link
Contributor Author

Salzian commented Apr 3, 2024

I'm currently on vacation. I will look at this again next week.

@Salzian
Copy link
Contributor Author

Salzian commented Apr 9, 2024

I overlooked the integTest folder. I fixed the tests to reflect the added public companion object.

@srinivasankavitha srinivasankavitha merged commit d33cbe2 into Netflix:master Apr 15, 2024
2 checks passed
@Salzian Salzian deleted the kotlin2-generate-companion-object-in-enum-classes branch April 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants