bug: TypedGraphQLError that have equal fields do not pass with equals()

[clandry94]

Please read our contributor guide before
creating an issue.

Expected behavior

Two TypedGraphQLError error instances that contain the same public fields should pass a equals() check. e.g.

firstError.equals(secondError) should return true when the message, locations, path, and extensions are equal. This makes it easier to compare semantically equal errors to each other during tests and runtime environments.

Actual behavior

Two TypedGraphQLError which contain the same fields return false when compared with equals()

Steps to reproduce

In Kotlin,

val firstError = TypedGraphQLError.newPermissionDeniedBuilder()
            .message("org.springframework.security.access.AccessDeniedException: Access is denied")
            .path(ResultPath.parse("/graphqlendpoint"))
            .build()

val secondError =  TypedGraphQLError.newPermissionDeniedBuilder()
            .message("org.springframework.security.access.AccessDeniedException: Access is denied")
            .path(ResultPath.parse("/graphqlendpoint"))
            .build()
            
firstError.equals(secondError) // false
firstError.toString().equals(secondError.toString()) // true

[srinivasankavitha]

Thanks for reporting!

[clandry94]

Thanks for ack'ing this 🙂 I can implement the correct behaviour and open a PR for this as well.

[srinivasankavitha]

That would be great! Thanks!

…

On Tue, Oct 19, 2021 at 9:56 AM Conor Landry ***@***.***> wrote: Thanks for ack'ing this 🙂 I can implement the correct behaviour and open a PR for this as well. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#700 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ5JPXPAFA4FVAEUV3W2HZ3UHWPLRANCNFSM5GJKZ2UA> .