Refactor InputArgumentTest #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the InputArgumentTest such that... 1. We don't have to duplicate setting the Dgs* components in the mocked Application Context. This is now done as `BeforeEach` step and only overwritten as needed with a new method `withComponents`, `withDirectives`, or `withScalars`. 2. The tests don't depend anymore on just asserting the serialized comparison of strings as the output of the _data fetcher_ but now also assert the expected input arguments in the _data fetcher_ themselves. 3. Add test cases, skipped for now, that can be used to replicate the [Issue 1083]. [Issue 1083]: #1083
berngp
force-pushed
the
feature/test-input-arguments
branch
from
5bfafc5
to
889a645
Compare
berngp
commented
May 31, 2022
| @@ -62,196 +48,3 @@ interface InputObjectMapper { | |||
| */ | |||
| fun <T> mapToJavaObject(inputMap: Map<String, *>, targetClass: Class<T>): T | |||
| } | |||
|
|
|||
| @Suppress("UNCHECKED_CAST") | |||
| class DefaultInputObjectMapper(val customInputObjectMapper: InputObjectMapper? = null) : InputObjectMapper { | |||
There was a problem hiding this comment.
Just moving this to its own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This commit refactors the InputArgumentTest such that...
Dgs*components in the mocked Application Context. This is now done asBeforeEachstep and only overwritten as needed with a set of new methods, which are thewithComponents,withDirectives, andwithScalars.