Addressing DgsGraphQLMetricsInstrumentation Latency increase #1092
+247
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the increased latencies observed on DGS 4.10.4, 5.0.0, 5.0.1. We are also adding support for JMH benchmarks across modules of DGS, that said we are only focusing in this commit on `graphql-dgs-spring-boot-micrometer`.
| @@ -177,18 +177,17 @@ class DgsGraphQLMetricsInstrumentation( | |||
| } | |||
| } | |||
|
|
|||
| override fun beginExecutionStrategy( | |||
| parameters: InstrumentationExecutionStrategyParameters | |||
There was a problem hiding this comment.
So switching to use InstrumenatationContext was the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This commit addresses the increased latencies observed on DGS 4.10.4, 5.0.0, 5.0.1.
We are also adding support for JMH benchmarks across modules of DGS, that said we are only focusing in this commit on
graphql-dgs-spring-boot-micrometer. To run benchmarks you can just call./gradlew graphql-dgs-spring-boot-micrometer:jmh.Fixes #1089