Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add configurable GraphiQl title property #1116

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

springmonster
Copy link
Contributor

@springmonster springmonster commented Jun 19, 2022

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

This PR is the feature that add configuration property to be able to change GraphiQl title
Both support webmvc and webflux

#602

Alternatives considered

  1. Add configuration
  2. When requesting graphiql endpoint, replace the placeholder of title

@springmonster
Copy link
Contributor Author

springmonster commented Jun 19, 2022

Dear @srinivasankavitha , @berngp , could you please help to check this PR?
Thanks very much!

@berngp
Copy link
Contributor

berngp commented Jun 21, 2022

Pretty cool @springmonster , thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants