Implement graphql-transport-ws protocol for websocket subscriptions (webmvc & webflux)
#1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berngp
approved these changes
Aug 24, 2022
berngp
reviewed
Aug 26, 2022
| @DefaultValue("/subscriptions") var path: String = "/subscriptions" | ||
| @DefaultValue("/subscriptions") var path: String = "/subscriptions", | ||
| /** Connection Initialization timeout in ms. */ | ||
| @DefaultValue("10000") var connectionInitTimeout: String = "10000" |
There was a problem hiding this comment.
Why not make this a Duration, Spring will handle changing the seconds (s), millis (ms), etc to the proper value.
srinivasankavitha
force-pushed
the
feat-subscriptions-graphql-ws
branch
from
0bc371a
to
990a810
Compare
srinivasankavitha
force-pushed
the
feat-subscriptions-graphql-ws
branch
from
990a810
to
7938fa7
Compare
This was referenced Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This PR adds support for the newer
graphql-transport-wsprotocol for websocket subscriptions.graphql-transport-wsimplemented in feat: implement GraphQL over WebSocket Protocol #686graphql-transport-wswith testsThe implementation is additive and preserves backwards compatibility with the deprecated
graphql-wsimplementation. The control flow is based on the presence of protocol headers. Eventually, we will remove support for the deprecated protocol, but for the time being, DGSs can support both clients.