Map unknown fields to additionalInformation in GraphQLErrorDebugInfo … #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The changes are looking good. Are you also able to verify that the changes don't break compatibility with existing usages of the debug info? |
|
@srinivasankavitha I have added a test which I believe covers the backward compat as well, there unfortunately wasn't a test covering it beforehand. If you can think of any edge cases I may have missed then please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#1600)
Pull request checklist
first
Pull Request type
Changes in this PR
Captures unmapped/unknown key-values in the error.extensions.debugInfo as addtionalInformation field instead of ignoring them during deserialization.
Issue #1600
Discussion: #1599
Alternatives considered
Describe alternative implementation you have considered