Fix classification type in GraphQLErrorExtensions #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphQLErrorExtensions' classification property had a type of String, but in practice an ErrorClassification may be mapped to any JSON serializable type; this is actually the case in practice when using libraries such as graphql-java-extended-validation, which may return a Map for its ErrorClassification. Switch the type to Any, so that such responses can be deserialized, and add a simple test case.
srinivasankavitha
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQLErrorExtensions' classification property had a type of String, but in practice an ErrorClassification may be mapped to any JSON serializable type; this is actually the case in practice when using libraries such as graphql-java-extended-validation, which may return a Map for its ErrorClassification. Switch the type to Any, so that such responses can be deserialized, and add a simple test case.
Fixes #1146