Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt kotlinter-gradle instead of org.jlleitschuh.gradle:ktlint-gradle #393

Merged
merged 1 commit into from Sep 25, 2021

Conversation

berngp
Copy link
Contributor

@berngp berngp commented Jun 9, 2021

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Migrate the Kotlin Format Task from org.jlleitschuh.gradle.ktlint to org.jmailen.kotlinter due recent failures while upgrading the first's minor version.

Alternatives considered

We could keep attempting to use org.jlleitschuh.gradle.ktlint and understand why 10.1.0 fails to serialize the com.pinterest.ktlint.reporter.plain.PlainReporterProvider. Error stacktrace below.

Caused by: java.io.NotSerializableException: com.pinterest.ktlint.reporter.plain.PlainReporterProvider
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
        at java.util.ArrayList.writeObject(ArrayList.java:768)
        at sun.reflect.GeneratedMethodAccessor605.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1154)
        at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
        at org.jlleitschuh.gradle.ktlint.worker.CurrentKtLintClassesSerializer.saveReporterProviders(KtLintClassesSerializer.kt:91)
        at org.jlleitschuh.gradle.ktlint.worker.LoadReportersWorkAction.execute(LoadReportersWorkAction.kt:33)

@paulbakker
Copy link
Collaborator

I don't have a preference for a specific plugin, so if this works better, that's fine

@berngp berngp closed this Aug 26, 2021
@berngp berngp reopened this Sep 25, 2021
@berngp berngp merged commit 4b668ec into master Sep 25, 2021
@berngp berngp deleted the feature/kotlinter-gradle branch October 20, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants