Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to APQ #923

Closed
wants to merge 8 commits into from
Closed

Updates to APQ #923

wants to merge 8 commits into from

Conversation

jord1e
Copy link
Contributor

@jord1e jord1e commented Mar 10, 2022

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes) <---
  • Build related changes
  • Other (please describe):

Changes in this PR

Fixes problems arising from #905 (will update description later)

afbeelding

Screenshots:

WebFlux smoke test (without Caffeine support):
afbeelding

WebMvc smoke test (with Caffeine support):
afbeelding

afbeelding

Alternatives considered

N/A

cc @berngp

@jord1e
Copy link
Contributor Author

jord1e commented Mar 10, 2022

Ping @berngp

@jord1e jord1e marked this pull request as ready for review April 9, 2022 13:09
@github-actions
Copy link

This pull request has been marked as stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale label Apr 20, 2023
@jord1e
Copy link
Contributor Author

jord1e commented Apr 22, 2023

@berngp is there still interest from Netflix in integrating this?

If yes I'll update it one last time

Otherwise, I'll close it :)

@github-actions github-actions bot removed the stale label Apr 23, 2023
@srinivasankavitha
Copy link
Contributor

@jord1e - Thanks so much for all the work. We won't be investing in this effort at this time due to other internal priorities. Internally, we use APQ differently and do not require APQ support on our DGSs at the moment. Feel free to close the PR and we will reopen at a more convenient time.

@Ancient-Dragon
Copy link
Contributor

I've run back my original issue, while upgrading to spring boot 3 and bringing in these dependencies:

        <dependency>
            <groupId>jakarta.ws.rs</groupId>
            <artifactId>jakarta.ws.rs-api</artifactId>
            <version>3.1.0</version>
        </dependency>
        <dependency>
            <groupId>org.glassfish.jersey.core</groupId>
            <artifactId>jersey-client</artifactId>
            <version>3.1.0</version>
        </dependency>
        <dependency>
            <groupId>org.glassfish.jersey.inject</groupId>
            <artifactId>jersey-hk2</artifactId>
            <version>3.1.0</version>
        </dependency>

Any chance we could get this merged in? Or is it going to break your integration? @srinivasankavitha

@srinivasankavitha
Copy link
Contributor

@Ancient-Dragon - we won't be merging this PR at this time since we are not using this feature and have conflicting internal priorities to invest in.

@kilink kilink closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants