Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings in DgsDataLoaderProvider #971

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

kilink
Copy link
Member

@kilink kilink commented Apr 10, 2022

Switch to DataLoaderFactory in DgsDataLoaderProvider. Additionally, change tests to use ApplicationContextRunner, instead of mocking the Spring ApplicationContext.

@kilink kilink requested a review from berngp April 11, 2022 16:57
@berngp berngp force-pushed the data-loader-provider-fixes branch 2 times, most recently from 1ce1780 to 396234d Compare April 11, 2022 20:23
Switch to DataLoaderFactory in DgsDataLoaderProvider. Additionally,
change tests to use ApplicationContextRunner, instead of mocking the
Spring ApplicationContext.
@berngp berngp force-pushed the data-loader-provider-fixes branch from 396234d to cb82dbd Compare April 11, 2022 22:58
@berngp berngp merged commit 20e891e into master Apr 11, 2022
@berngp berngp deleted the data-loader-provider-fixes branch October 20, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants