Get rid of unnecessary .let, use MediaType #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berngp
reviewed
Apr 11, 2022
| @@ -71,6 +72,11 @@ open class DgsRestController( | |||
| open val mapper: ObjectMapper = jacksonObjectMapper() | |||
| ) { | |||
|
|
|||
| companion object { | |||
There was a problem hiding this comment.
Isn't the Kotlin convention to put the companion object at the bottom?
There was a problem hiding this comment.
You're right, I guess it is, according to this; guess it just feels weird to me to put constants / loggers at the end of a class.
berngp
approved these changes
Apr 11, 2022
berngp
force-pushed
the
dgs-rest-controller-cleanup
branch
2 times, most recently
from
66ed918
to
2f571fe
Compare
Get rid of unnecessary .let calls where the varaible was already smart cast or known to not be null. Also, switch to MediaType class for request content type check.
berngp
force-pushed
the
dgs-rest-controller-cleanup
branch
from
2f571fe
to
49b76e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of unnecessary .let calls where the varaible was already smart cast or known to not be null. Also, switch to MediaType class for request content type check.