Avoid passing in empty ChainedInstrumentation #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no Instrumentation beans are supplied, avoid passing in a ChainedInstrumentation instance containing an empty list of Instrumentations. Doing so would result in some unnecessary overhead, as the builder's internal checkInstrumentationDefaultState method will attempt to add its own default instrumentation.
kilink
commented
Apr 18, 2022
| .queryExecutionStrategy(queryExecutionStrategy) | ||
| .mutationExecutionStrategy(mutationExecutionStrategy) | ||
| .subscriptionExecutionStrategy(SubscriptionExecutionStrategy()) |
There was a problem hiding this comment.
SubscriptionExecutionStrategy(this.defaultExceptionHandler) is what gets aded by default if no execution strategy is supplied for subscriptions; it seems better to rely on the builder's default, imo, unless we were doing this to avoid having the defaultExceptionHandler set?
berngp
approved these changes
Apr 19, 2022
|
Thanks @kilink |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no Instrumentation beans are supplied, avoid passing in a ChainedInstrumentation
instance containing an empty list of Instrumentations. Doing so would result in some
unnecessary overhead, as the builder's internal checkInstrumentationDefaultState method
will attempt to add its own default instrumentation.
Not that I did actually see this show up in flame graphs, for a case where I had no instrumentation registered, it was spending time in ChainedInstrumentation's internals, looking up state in a HashMap, etc. This is because by passing in an empty ChainedInstrumentation, we end up with the default DataLoaderDispatcherInstrumentation instance wrapped unnecessarily in a ChainedInstrumentation.