Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues around discovery failure #34

Closed
wants to merge 5 commits into from
Closed

Issues around discovery failure #34

wants to merge 5 commits into from

Conversation

honglh
Copy link

@honglh honglh commented Sep 3, 2020

This PR address the often occurred discovery failures

  1. the ssdp_search sets the MX value to 10, allowing the device to have upto 10 seconds to respond. Yet, the RESPONSE_TIMEOUT is set to 5 seconds. The wait loop may exit too early.

In the PR, set MX to 3 which should be enough for today's network (home broadband), and reasonably within the wait period (RESPONSE_TIMEOUT)

  1. socket descriptors and wait time should be reset on every select() call

  2. change location header search to case-insensitive search

  3. remove the check for optional (space) after "Application-URL" in HTTP header (otherwise the URL gets dropped)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant