Avoid duplicate documents on update

Netflix · Sep 30, 2020 · e905295 · e905295
1 parent f88593d
commit e905295
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/dispatch/document/service.py b/src/dispatch/document/service.py
@@ -107,6 +107,19 @@ def create(*, db_session, document_in: DocumentCreate) -> Document:
     return document
 
 
+def get_or_create(*, db_session, document_in) -> Document:
+    if hasattr(document_in, "resource_id"):
+        q = db_session.query(Document).filter(Document.resource_id == document_in.resource_id)
+    else:
+        q = db_session.query(Document).filter_by(**document_in.dict())
+
+    instance = q.first()
+    if instance:
+        return instance
+
+    return create(db_session=db_session, document_in=document_in)
+
+
 def update(*, db_session, document: Document, document_in: DocumentUpdate) -> Document:
     """Updates a document."""
     document_data = jsonable_encoder(document)

diff --git a/src/dispatch/workflow/service.py b/src/dispatch/workflow/service.py
@@ -116,7 +116,7 @@ def update_instance(*, db_session, instance: WorkflowInstance, instance_in: Work
     )
 
     for a in instance_in.artifacts:
-        artifact_document = document_service.create(db_session=db_session, document_in=a)
+        artifact_document = document_service.get_or_create(db_session=db_session, document_in=a)
         instance.artifacts.append(artifact_document)
 
     for field in instance_data: