Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incident type plugin metadata UI #1643

Merged
merged 5 commits into from Sep 27, 2021
Merged

Conversation

kevgliss
Copy link
Contributor

No description provided.

@kevgliss kevgliss added the bug Something isn't working label Sep 23, 2021
@mvilanova
Copy link
Contributor

Pulled the PR locally. Getting none is not an allowed value when trying to save. Also, the + button to add an item does not work.

Screen Shot 2021-09-23 at 3 24 02 PM

@mvilanova
Copy link
Contributor

Looks like the PluginMetadata Pydantic model expects slug but we're not providing it:

{"detail":[{"loc":["body","plugin_metadata",0,"slug"],"msg":"none is not an allowed value","type":"type_error.none.not_allowed"}]}

@kevgliss kevgliss merged commit d90e431 into master Sep 27, 2021
@kevgliss kevgliss deleted the bugfix/plugin-metadata branch September 27, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants