Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to using CLI to install plugins #2569

Merged
merged 3 commits into from Oct 3, 2022

Conversation

caioaao
Copy link
Contributor

@caioaao caioaao commented Oct 3, 2022

I've spent a considerable amount of time trying to debug why the plugins wouldn't show up in the Add Plugin form in the dashboard. Maybe it's missing because most people start with the prepopulated DB? If so, wouldn't it be better to add some of this to the init db script?

@mvilanova mvilanova self-requested a review October 3, 2022 21:40
@mvilanova
Copy link
Contributor

Thanks for the PR. I think it would be better if we add a new section called Install here and we reference it here.

@mvilanova
Copy link
Contributor

We may want to take the opportunity and fix the dispatch command in the List section where we say dispatch database list instead of dispatch plugins list.

@mvilanova mvilanova added the documentation Improvements or additions to documentation label Oct 3, 2022
@mvilanova
Copy link
Contributor

@caioaao thanks for fixing the command. Not sure if you saw my suggestion in this comment: #2569 (comment)

Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvilanova mvilanova merged commit 0e78509 into Netflix:master Oct 3, 2022
@caioaao caioaao deleted the document-plugin branch October 3, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants