Add Entity Type create dialog and Entity Type playground editor #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
added
enhancement
wssheldon
changed the title
wssheldon
commented
Mar 2, 2023
Comment on lines
+287
to
+290
| /** | ||
| * This function sets up the draggable feature for the signal table and the playground editor. | ||
| * Updates the editor value with the selected signal raw JSON when dragging ends. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * This function sets up the draggable feature for the signal table and the playground editor. | |
| * Updates the editor value with the selected signal raw JSON when dragging ends. | |
| */ |
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…lix#3008) * initial scaffolding for mvp version of entity creation playground/dialog
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockup
Divided areas are expandable with arrow buttons. Regex and JSONPath text area's auto-grow. Option to load signal data from prior signals or just put any arbitrary json blob. Highlight matching for values that match the supplied entity type pair (jsonpath +/- regex).
Retrieve list of all signal instances over last 30 days and run javascript version of
find_entitiesfunction that checks the entity type pair supplied in realtime as the user updates theregexorjsonpathtext area. Matches are returned and update the playground JSON object with any matches via CSS highlighting.Create Dialog
MVP
The MVP here is everything minus the right hand side JSON playground. We should still check for matches with the supplied values and display a count + table of matches.
Implementation