Remove unnecessary * parameter in views, create CommonParameters and CurrentIncident Annotated types
#3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
commented
Mar 31, 2023
| @@ -448,6 +448,12 @@ def common_parameters( | |||
| } | |||
|
|
|||
|
|
|||
| CommonParameters = Annotated[ | |||
| dict[str, int | CurrentUser | DbSession | QueryStr | Json | List[str] | List[bool] | UserRoles], | |||
There was a problem hiding this comment.
This should likely be a Pydantic model or TypedDict
There was a problem hiding this comment.
I'd lean on using a Pydantic model so we can do data validation.
mvilanova
approved these changes
Apr 3, 2023
|
Python CI test failure is not related to this change and is resolved in: #3207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unnecessary
*parameter in views: https://fastapi.tiangolo.com/tutorial/path-params-numeric-validations/#order-the-parameters-as-you-need-tricks