Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes side bar loading #3459

Merged
merged 1 commit into from Jun 2, 2023
Merged

Fixes side bar loading #3459

merged 1 commit into from Jun 2, 2023

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Jun 2, 2023

No description provided.

@kevgliss kevgliss added the bug Something isn't working label Jun 2, 2023
@wssheldon
Copy link
Contributor

Will the filter for 5 per page in getSignalData be effectively the same as if we did LIMIT 5 ? Just want to make sure we don't fetch every signal instance on component creation if we only need to show 5 of them.

@kevgliss
Copy link
Contributor Author

kevgliss commented Jun 2, 2023

That's right, it eventually turns into a limit clause in the query.

@kevgliss kevgliss merged commit f811ab6 into master Jun 2, 2023
9 checks passed
@kevgliss kevgliss deleted the bugfix/entity-type-sidebar branch June 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevgliss @wssheldon