Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to conduct global search via the URL #3633

Merged
merged 5 commits into from Jul 31, 2023

Conversation

whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Jul 28, 2023

This PR adds the global search query to the URL, providing a way to copy & paste the search query, and allowing direct access to search results via URL. For instance, https://dispatch.com/org/search/results?q=281 will show the search results for the query "281".

@whitdog47 whitdog47 added the enhancement New feature or request label Jul 28, 2023
@whitdog47 whitdog47 requested a review from wssheldon July 28, 2023 22:08
@kevgliss kevgliss self-requested a review July 28, 2023 22:08
@kevgliss
Copy link
Contributor

Thoughts on using a query param here? When I think of a search query I typically think of something like /search?q=foo mostly because I'd expect the result to be dynamic. Where as if it's directly in the URL id expect the results to be the same every time.

@whitdog47
Copy link
Contributor Author

Thanks for the suggestion, @kevgliss. I changed to a query parameter and improved further by updating the URL bar and search results when user types in the inputbox.

@whitdog47 whitdog47 merged commit ee021f1 into master Jul 31, 2023
6 of 7 checks passed
@whitdog47 whitdog47 deleted the enhancement/search-via-url branch July 31, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants