Adding a new command to display only the requesting user's tasks #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
reviewed
Jun 5, 2020
Comment on lines
+227
to
+241
| def filter_tasks_by_assignee_and_creator(tasks: List[Task], by_assignee: str, by_creator: str): | ||
| """Filters a list of tasks looking for a given creator or assignee.""" | ||
| filtered_tasks = [] | ||
| for t in tasks: | ||
| if by_creator: | ||
| creator_email = t.creator.individual.email | ||
| if creator_email == by_creator: | ||
| filtered_tasks.append(t) | ||
|
|
||
| if by_assignee: | ||
| assignee_emails = [a.individual.email for a in t.assignees] | ||
| if by_assignee in assignee_emails: | ||
| filtered_tasks.append(t) | ||
|
|
||
| return filtered_tasks |
There was a problem hiding this comment.
Should we move this to the task service and make it a db query instead?
There was a problem hiding this comment.
We could but the query will be fairly complex and the task lists are normally small so filtering after the fact seems reasonable.
mvilanova
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.