Skip to content

Commit

Permalink
Fix Peer Dnode Mismatches
Browse files Browse the repository at this point in the history
There was an edge case in the dnode header parsing where we were dropping a
dnode message from a peer. This happens when the dnode header arrives in one
packet and rest of the message arrives in another packet. This fix will further
reduce inconsistencies in the database.

Yay!!
  • Loading branch information
shailesh33 committed Nov 16, 2015
1 parent 03689fc commit ce9b818
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/dyn_dnode_msg.c
Expand Up @@ -307,7 +307,6 @@ dyn_parse_core(struct msg *r)
}
if (*p == LF) {
dyn_state = DYN_DONE;
r->pos = p;
} else {
token = NULL;
dyn_state = DYN_START;
Expand Down

1 comment on commit ce9b818

@timiblossom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense when the packet ends there, we need to get more data and re-parse from the right position instead of losing track. Yeah, we missed this case.

Please sign in to comment.