Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote region registry lookup failure should not disable registry fetch #157

Closed
NiteshKant opened this issue Jul 30, 2014 · 1 comment
Closed
Assignees
Milestone

Comments

@NiteshKant
Copy link
Contributor

Eureka server does not allow fetch registry if there is a remote region registry fetch configured and the remote region server is unavailable. Relevant code is here

This creates a circular dependency between two regions configured to fetch registry data from each other (which is typically the case) and hence makes it impossible to bootstrap two dependent regions.

This behavior should be altered such that remote region registry fetch is a 'best-effort' and any failure to retrieve this registry does not hamper clients fetching registry information.

Open question

Should we only disallow fetch registry calls that requires remote region data in this scenario?

@NiteshKant NiteshKant added this to the 1.1.138 milestone Jul 30, 2014
@NiteshKant NiteshKant self-assigned this Jul 30, 2014
@NiteshKant
Copy link
Contributor Author

PR #158 fixes this issue.

Should we only disallow fetch registry calls that requires remote region data in this scenario?

This change disallows remote registry fetch calls when remote region registry is not available. The local region registry fetch is allowed.

NiteshKant added a commit that referenced this issue Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant