Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable injection of BackupRegistry in DiscoveryClient #174

Closed
NiteshKant opened this issue Aug 25, 2014 · 0 comments
Closed

Enable injection of BackupRegistry in DiscoveryClient #174

NiteshKant opened this issue Aug 25, 2014 · 0 comments
Assignees
@NiteshKant
Milestone
1.1.139

Comments

@NiteshKant
Copy link
Contributor

Currently DiscoveryClient uses reflection to instantiate BackupRegistry.
This makes it impossible for BackupRegistry to use injection.
@NiteshKant NiteshKant added this to the 1.1.139 milestone Aug 25, 2014
@NiteshKant NiteshKant self-assigned this Aug 25, 2014
NiteshKant added a commit that referenced this issue Aug 26, 2014
@NiteshKant
Merge pull request #176 from NiteshKant/master
6f3fa3f 
Fixes #174
NiteshKant pushed a commit to NiteshKant/eureka that referenced this issue Aug 27, 2014
Adding the modified public constructor to DiscoveryClient
dee6c75 
Fix for issue Netflix#174 added another argument to the constructor used by guice.
This was considering the fact that code should not be using the @Inject constructor directly. However, some code inside Netflix was dependent on it.

 Adding the old constructor back and making the @Inject constructor package private.
@NiteshKant NiteshKant mentioned this issue Aug 27, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
None yet
Projects
None yet
Milestone
1.1.139
Development

No branches or pull requests
1 participant
@NiteshKant