Add shouldEnforceFetchRegistryAtInit config #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troshko111
reviewed
Jun 17, 2020
| @@ -435,8 +435,19 @@ public synchronized BackupRegistry get() { | |||
| throw new RuntimeException("Failed to initialize DiscoveryClient!", e); | |||
| } | |||
|
|
|||
| if (clientConfig.shouldFetchRegistry() && !fetchRegistry(false)) { | |||
| fetchRegistryFromBackup(); | |||
| if (clientConfig.shouldFetchRegistry()) { | |||
There was a problem hiding this comment.
I think the logic here is off, you want to
if (shouldFetch) {
fetch
if (unsuccessful) {
log at info that the normal fetch failed
fetch from backup
if still unsuccessful, log a detailed msg and throw
}
}
Right now you're fetching and then fetching again from backup on success.
There was a problem hiding this comment.
Good catch. I revisited this logic and tried to clean it up. The changes should now require that fetching from both the primary and backup registry fail before applying the shouldEnforceFetchRegistryAtInit configuration.
troshko111
requested changes
Jun 17, 2020
We add a `shouldEnforceFetchRegistryAtInit` configuration to support users that want the Eureka client to fail fast during initialization. If `shouldEnforceFetchRegistryAtInit` is set to `true` then the client will throw an `IllegalStateException` during instance construction if its initial attempt to fetch of information from the remote Eureka servers (both primary and backup) is unsuccessful. This setting does not have an effect if `shouldFetchRegistry` is set to `false`. We also update `fetchRegistryFromBackup` to return `true` if successful.
yobennett
force-pushed
the
feature/add-should-enforce-fetch-registry-at-init
branch
from
2b64ca6
to
2b8c018
Compare
troshko111
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
shouldEnforceFetchRegistryAtInitconfiguration to support users that want the Eureka client to fail fast during initialization. IfshouldEnforceFetchRegistryAtInitis set totruethen the client will throw anIllegalStateExceptionduring instance construction if its initial attempt to fetch of information from the remote Eureka servers is unsuccessful. This setting does not have an effect ifshouldFetchRegistryis set tofalse.