Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove null check code #1312

Closed
wants to merge 1 commit into from
Closed

remove null check code #1312

wants to merge 1 commit into from

Conversation

Hanope
Copy link
Contributor

@Hanope Hanope commented Jun 27, 2020

I think it is unnecessary to check the null of instanceStatus.
Because it doesn't matter if instanceStatus is null when calling overrideStatus.equals

@troshko111
Copy link
Contributor

You're correct from the logical perspective and the change will be equivalent, but it looks to me the intent of the check was readability(?), it reads "if no override or unequal override", without the null check it makes you think harder what the intent is.

@troshko111 troshko111 closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants