-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemSocket support - alternative approach #235
Conversation
com.netflix.eureka.shouldSSLConnectionsUseSystemSocketFactory is set to true
Remove an import I left behind from the previous change Correct the visibility of SystemSSLCustomApacheHttpClientConfig
eureka-pull-requests #293 SUCCESS |
@@ -145,6 +232,18 @@ public CustomApacheHttpClientConfig(String clientName, int maxConnectionsPerHost | |||
} | |||
} | |||
|
|||
private static class ProxyCustomApacheHttpClientConfig extends DefaultApacheHttpClient4Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is never used.
The implementation looks good, and covers all the important cases that I can think of. |
configuration in EurekaJerseyClient.createProxyJerseyClient when I initially refactored this.
eureka-pull-requests #294 FAILURE |
if (eurekaServiceUrls.get().get(0).startsWith("https://") && | ||
"true".equals(System.getProperty("com.netflix.eureka.shouldSSLConnectionsUseSystemSocketFactory"))) { | ||
discoveryJerseyClient = EurekaJerseyClient.createSystemSSLJerseyClient("DiscoveryClient-HTTPClient-System", | ||
clientConfig.getEurekaServerConnectTimeoutSeconds() * 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just pass the client config to the EurekaJerseyClient?
The change looks good to me. |
SystemSocket support - alternative approach
@keithbranton Thank you for your contribution. |
Alternative pull request including refactor to DiscoveryClient so that it uses a factory method.