SystemSocket support - alternative approach #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.netflix.eureka.shouldSSLConnectionsUseSystemSocketFactory is set to true
Remove an import I left behind from the previous change Correct the visibility of SystemSSLCustomApacheHttpClientConfig
|
eureka-pull-requests #293 SUCCESS |
| @@ -145,6 +232,18 @@ public CustomApacheHttpClientConfig(String clientName, int maxConnectionsPerHost | |||
| } | |||
| } | |||
|
|
|||
| private static class ProxyCustomApacheHttpClientConfig extends DefaultApacheHttpClient4Config { | |||
|
The implementation looks good, and covers all the important cases that I can think of. |
configuration in EurekaJerseyClient.createProxyJerseyClient when I initially refactored this.
|
eureka-pull-requests #294 FAILURE |
| if (eurekaServiceUrls.get().get(0).startsWith("https://") && | ||
| "true".equals(System.getProperty("com.netflix.eureka.shouldSSLConnectionsUseSystemSocketFactory"))) { | ||
| discoveryJerseyClient = EurekaJerseyClient.createSystemSSLJerseyClient("DiscoveryClient-HTTPClient-System", | ||
| clientConfig.getEurekaServerConnectTimeoutSeconds() * 1000, |
There was a problem hiding this comment.
Why not just pass the client config to the EurekaJerseyClient?
|
The change looks good to me. |
tbak
pushed a commit
that referenced
this pull request
Oct 31, 2014
SystemSocket support - alternative approach
|
@keithbranton Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative pull request including refactor to DiscoveryClient so that it uses a factory method.