Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where shuffleVirtualHostNameMap isn't updated #240

Merged
merged 1 commit into from
Nov 6, 2014

Conversation

pgkelley4
Copy link
Contributor

shuffleVirtualHostNameMap and shuffledSecureVirtualHostNameMap were
not being updated when the last instance was removed from an application.

Added unit test to illustrate the issue and fixed it by clearing the map
on every update, just as virtualHostNameAppMap gets cleared.

shuffleVirtualHostNameMap and shuffledSecureVirtualHostNameMap were
not being updated when the last instance was removed from an application.

Added unit test to illustrate the issue and fixed it by clearing the map
on every update, just as virtualHostNameAppMap gets cleared.
@cloudbees-pull-request-builder

eureka-pull-requests #299 SUCCESS
This pull request looks good

tbak pushed a commit that referenced this pull request Nov 6, 2014
Fix bug where shuffleVirtualHostNameMap isn't updated
@tbak tbak merged commit 65e0ef9 into Netflix:master Nov 6, 2014
@tbak
Copy link

tbak commented Nov 6, 2014

Thank you for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants