Improve rate limiter to throttle only full and delta registry fetches. #241
Conversation
|
|
||
| if ("GET".equals(httpRequest.getMethod())) { | ||
| String path = httpRequest.getPathInfo(); | ||
| if (path.endsWith("/apps") || path.endsWith("/apps/")) { |
There was a problem hiding this comment.
ApplicationsResource also allows calls of the format /apps/{appId} for specific applications, we would want to cover this Target type here too. If we don't want to introduce more Target types it could roll up into FullFetch.
There was a problem hiding this comment.
I did not include this on purpose, as majority of clients will do full/delta registry fetch. If we would like to include this as well, we can add another target type.
There was a problem hiding this comment.
That makes sense too. We did add a feature to the client recently that allows clients to be configured to change it's periodic fetch from a full_all/delta_all pattern to be always full_single_app, so I just don't want this feature to become a backdoor to get around the rateLimiter.
There was a problem hiding this comment.
I will add apps/<app_id> to the full fetch bucket.
|
eureka-pull-requests #300 SUCCESS |
|
eureka-pull-requests #301 FAILURE |
|
eureka-pull-requests #302 SUCCESS |
Improve rate limiter to throttle only full and delta registry fetches.
No description provided.