1.x Fix batch request/response encoding for the new Jackson codec. #674
Conversation
|
NetflixOSS » eureka » eureka-pull-requests #479 SUCCESS |
| }; | ||
|
|
||
| // In replication channel we use JSON only | ||
| List<CodecWrapper> jsonCodes = Arrays.asList( |
There was a problem hiding this comment.
what about the reverse (encoded with JacksonJson and decoded with Legacy)?
There was a problem hiding this comment.
The test covers all combinations:
Encoding ReplicationList using {JacksonJson,JacksonJson}
Encoding ReplicationList using {JacksonJson,LegacyJacksonJson}
Encoding ReplicationList using {LegacyJacksonJson,JacksonJson}
Encoding ReplicationList using {LegacyJacksonJson,LegacyJacksonJson}
Encoding ReplicationListResponse using {JacksonJson,JacksonJson}
Encoding ReplicationListResponse using {JacksonJson,LegacyJacksonJson}
Encoding ReplicationListResponse using {LegacyJacksonJson,JacksonJson}
Encoding ReplicationListResponse using {LegacyJacksonJson,LegacyJacksonJson}
On Tue, Oct 6, 2015 at 2:50 PM, David Liu notifications@github.com wrote:
In
eureka-client/src/test/java/com/netflix/discovery/converters/EurekaCodecCompatibilityTest.java
#674 (comment):
Action.Register));final ReplicationList replicationList = new ReplicationList(replicationInstances);
Action2 codingAction = new Action2() {@Overridepublic void call(EncoderWrapper encodingCodec, DecoderWrapper decodingCodec) throws IOException {String encodedString = encodingCodec.encode(replicationList);
ReplicationList decodedValue = decodingCodec.decode(encodedString, ReplicationList.class);assertThat(decodedValue.getReplicationList().size(), is(equalTo(1)));}};
// In replication channel we use JSON onlyList<CodecWrapper> jsonCodes = Arrays.asList(what about the reverse (encoded with JacksonJson and decoded with Legacy)?
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/eureka/pull/674/files#r41327448.
There was a problem hiding this comment.
Ahh yes, thanks. I misread.
|
NetflixOSS » eureka » eureka-pull-requests #480 SUCCESS |
|
Ship it. |
1.x Fix batch request/response encoding for the new Jackson codec.
No description provided.