1.x Client InstanceInfo default address resolution #716
Conversation
"default" network address based on data available in AmazonInfo.
|
NetflixOSS » eureka » eureka-pull-requests #526 FAILURE |
| * @return either a hostname or an ipAddress | ||
| */ | ||
| @JsonIgnore | ||
| public String getDefaultAddress() { |
There was a problem hiding this comment.
Why this need method is needed, if it just returns hostName?
There was a problem hiding this comment.
Ideally, it would be nice to get rid of the toplevel hostname/ipAddr fields and just have users access them from DataCenterInfo. At the toplevel, what's nice to have is a default "address" that can be either hostname or ip, as defined by the registering service itself. Unfortunately, for backwards compatibility, the hostname field is today the realistic data that's used for this. Introducing this new accessor for a cleaner client API.
|
NetflixOSS » eureka » eureka-pull-requests #527 SUCCESS |
|
NetflixOSS » eureka » eureka-pull-requests #528 SUCCESS |
|
Looks good |
1.x Client InstanceInfo default address resolution
Adding ability to define resolution order of the local InstanceInfo's "default" network address based on data available in AmazonInfo.