Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable and CompositeDisposable declared but not used #573

Closed
HenriqueLimas opened this issue Oct 14, 2015 · 2 comments
Closed

Observable and CompositeDisposable declared but not used #573

HenriqueLimas opened this issue Oct 14, 2015 · 2 comments

Comments

@HenriqueLimas
Copy link
Contributor

In the CallResponse.js the Observable and the CompositeDisposable are declared but not used. It seems strange, is that correct?

@falcor-build
Copy link
Contributor

Wii Wii, I think our eslint isn't catching such simple errors!

On Tue, Oct 13, 2015, 6:58 PM Henrique Limas notifications@github.com
wrote:

In the CallResponse.js
https://github.com/Netflix/falcor/blob/master/lib/response/CallResponse.js#L2
the Observable and the CompositeDisposable are declared but not used. It
seems strange, is that correct?


Reply to this email directly or view it on GitHub
#573.

You received this message because you are subscribed to the Google Groups
"Falcor" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to falcor+unsubscribe@netflix.com.
To post to this group, send email to falcor@netflix.com.
To view this discussion on the web visit
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/issues/573%40github.com
https://groups.google.com/a/netflix.com/d/msgid/falcor/Netflix/falcor/issues/573%40github.com?utm_medium=email&utm_source=footer
.

@HenriqueLimas
Copy link
Contributor Author

The gulp lint is working but gulp all, used in the dist script in the package.json, is not calling the lint task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants