Fixed deref completing, without onNext'ing a bound model, if the preload paths fail #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the case where we have successfully deref'd, but all or some of the preload paths fail. We could still return a bound model, and then let any follow up requests for data take their proper onNext/onError path.
|
boom. Take that 1. |
sdesai
added a commit
that referenced
this pull request
Dec 15, 2015
Fixed deref completing, without onNext'ing a bound model, if the preload paths fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were swallowing errors on preload paths, and not onNexting a successfully bound model as a result.
This PR aims to fix that (For the current 0.x deref. It's N/A for the new 1.x/master deref).
@michaelbpaulson - Could you take a quick look at this, including the unit tests (to make sure I'm testing the correct 'as designed' expectation).