Fix max retries on clone #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quantumew |
|
@asyncanup Thanks for the fast response. c77bc07 |
Remove extra line I added to spec file
|
@asyncanup Sorry to bother, do you have a timeline for this to be released? Just curious, thanks again for the time! Let me know if I am missing anything! |
|
LGTM |
|
will wait a day to let other reviewers review this (added them to the PR), and then merge into master. |
|
@asyncanup Awesome, thank you sir! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#915
No clue if you guys take pull requests but this appears to fix the issue above.
For ease of reading at a glance I will reiterate what this is fixing. batch calls this._clone, _clone instantiates Model with
this, the instance of the model does not have a property maxRetries but rather _maxRetries, therefore maxRetries gets reset to the default if you do the followingnew falcor.Model({maxRetries: 10, ... }).batch(...)Also I can write a test for this if you'd like